[Soot-list] a small bug in PDG

[Eric Bodden]

Thanks, I have committed the patch.

Eric

On 30 June 2012 12:06, lpxz <lpxz at ust.hk> wrote:
> Hi, guys,
>    In HashMutablePDG class, the getDependents method should only return
> the dependents, but the implementation returns all successors, a
> superset of the dependents. An extra check is needed to fix the bug, as
> follows.
>
>
> public List<PDGNode> getDependents(PDGNode node)
> {
>        //return this.getSuccsOf(node);// wrong! auxiliary edges exist.
>        List<PDGNode> toret = new ArrayList<PDGNode>();//memory issue
>        for(Object succ:this.getSuccsOf(node))
>        {
>                        PDGNode succPDGN = (PDGNode)succ;
>                        if(this.dependentOn(succPDGN, node))
>                        {
>                                toret.add(succPDGN);
>                        }
>        }
>        return toret;
> }
>
> Regards
> Peng
>
> _______________________________________________
> Soot-list mailing list
> Soot-list at sable.mcgill.ca
> http://mailman.cs.mcgill.ca/mailman/listinfo/soot-list



-- 
Eric Bodden, Ph.D., http://bodden.de/
Head of Secure Software Engineering Group at EC SPRIDE
Principal Investigator in Secure Services at CASED
Tel: +49 6151 16-75422    Fax: +49 6151 16-72051
Room 3.2.14, Mornewegstr. 30, 64293 Darmstadt