[abc] Around unweaver

From: Ondrej LHOTAK <olhotak@sable.mcgill.ca>
Date: Fri Sep 10 2004 - 23:12:53 BST

I've checked in the changes to the unweaver for around advice that we
agreed on with Sascha. Specifically, the unweaver now restores method
signatures and fields, in addition to the bodies and methods that it
always did.

The failing test count is now 280, down from 299. Most of these seem
to be from missing locals (the weaver remembers that it once wove a
local, and fails to weave it when re-weaving). However, I do also
get a number of "ARD around weaver internal error". The majority of
these appear to also be due to missing locals (the around weaver looks
for a local and throws the error when it doesn't find it), so are
probably not caused by the around weaver itself. A few of them come from
abc.weaving.weaver.AroundWeaver$AdviceMethod$ProceedMethod$
AdviceApplicationInfo.findReturnedLocal(AroundWeaver.java:1693).
Judging by the name of the method, they may also have something to do
with locals, but the problem where this happens appears to be advice
applying to an unexpected statement type.

Ondrej
Received on Fri Sep 10 23:12:59 2004

This archive was generated by hypermail 2.1.8 : Sat Sep 11 2004 - 02:30:01 BST