[abc] Paper comments

Here are some (subjective) suggestions for corrections. This is based on
Pavel's PDF from last night.
I found the paper very readable and most of the suggestions merely
involve commas which I think are unnecessary. I tried to verify some of
these by finding similar sentences on google, but since my comma
suggestions are largely based on intuition I may be wrong in some cases
(feel free to skip them if you disagree :-).
I apologize if some of these have already been mentioned or fixed (which
leads me to ask: where are the current source files for the document?).
If most of these suggestions seem right, I'd be glad to put them in
myself.

Cheers,

Sascha

"abc" appears in a very large font, and the letter "c" usually gets
placed too close to the next letter (actually, the fixed spaced font
generally seems too large).

"In particular, new features for AspectJ have been proposed that require
extensions in many dimensions: syntax, type checking, code generation,
as well as data flow and control flow analyses."
=>
"In particular, new features for AspectJ have been proposed that require
extensions in many dimensions such as syntax, type checking, code
generation as well as data flow and control flow analyses."

"abc is freely available under the GNU LGPL, and can be downloaded from
[1]." - no comma

"An AspectJ compiler is already a complex piece of software, which, in
addition to the normal" - drop first comma, drop "already"

"frontend and backend components for a compiler" - change to "of a
compiler"

"Their integration into AspectJ requires substantial changes to the type
system, as well as the intertype weaver." - no comma

"where aspect instances are tied to a group of objects, to express
behavioural relationships" - no comma

"a new type of pointcut, called predicted" - no comma

"path to a another shadow" - drop the "a"

"flexible implementation of the type system, as well as the matchers" -
no comma

"relatively simple develop" - add "to"

"should be very modular, so that the different facets" - no comma

"may require relatively sophisticated analysis" - change to "analyses"

"namely the Polyglot extensible compiler framework for the frontend
[23], and the Soot analysis" - no comma

"separates the AspectJ program into a pure Java part, and instructions
for the weaver." =>
"separates the AspectJ program into a pure Java part and a part
containing instructions for the weaver."

"abc is an instance of such a workbench with a clean, extensible
architecture." change to "We present abc, an instance..." to emphasize
it's a contribution of the paper

"substantial exercise in aspect-oriented software development, with the
primary goal" - no comma

"In Section 2 we first give an overview" - could use a comma before "we"

"Next, in Section 3 we" - comma before "we"

"Finally in Section 7 we" - two commas

"it is easy for us, as the developers of abc itself, to update to the" -
drop both commas

"intermediate representation is a typed, stack-less, three-address
code." - drop second comma

"the weaver would need to consider the effect of the woven code on the
implicit execution stack, and generate additional code" - no comma

"Soot first uses Polyglot to construct an AST with type information, and
then" - no comma

"Soot builds a class hierarchy, with mere stubs for the methods" - no
comma

"named class pattern expressions, along the lines suggested in [6]." -
no comma

"which indicates how the each node affects the environment" - drop first
"the"

"stripping out all aspect-specific constructs, and storing them" - no
comma

"For instance, the following pointcut could be used to check that it is
either a negative int or a negative double:" - replace "it" with "the
argument"

"A corresponding new type of join point shadow is added, which occurs at
every cast instruction, whether for reference or primitive types, in the
bytecode of a program."
=>
"A corresponding new type of join point shadow is added which occurs at
every cast instruction in the bytecode of a program, whether for
reference or primitive types."

"and result of the cast can" - missing "the"

"matched by the optional parameter to after returning advice" - change
"to" to "of". Also, proceed in around advice can be used to fetch the
value, right?

Section 5.5, listing: "protected List" - is there a space missing
between "protected" and "List"?

"exception handler table for a method, rather than its statements" - no
comma

"This happens just once, in the static initialiser of the class where
the join point shadow is located." - add "namely" after comma

"which is to directly generating code to construct these objects" -
change to "generate"

"So that we can easily" - change to "To allow us to easily" (not sure
about this, but "So" at the beginning of the sentence seems unusual)

"we review a number of such proposals, and contrast them with the" - no
comma

"the time has now come to disentangle the code of the base compiler from
those of the extensions." change "those" to "that"

"suggested an open implementation of pointcuts, to enable easy
experimentation" - no comma

"We have presented abc, and its use as a workbench for experimentation
with extensions of AspectJ." - no comma

"extensibility of Polyglot and Soot, from the perspective of
aspect-oriented software development" - no comma

"We now summarise their role in the extensibility of our design, and
identify possible improvements." - no comma

"using open classes in lieu of Polyglot's delegate and extension nodes,
to implement his recent work on predicate dispatch" - no comma

"The reflection route has been used with much success, in a framework
that is very similar to Polyglot, by Hanson and Proebsting [14]."
=>
"The reflection route has been used with much success in a framework by
Hanson and Proebsting [14] that is very similar to Polyglot."

"In such cases, one needs to first weave naively, to get an
approximation of the relevant analysis structures." - drop second comma
Received on Wed Sep 29 17:15:10 2004