Re: [abc-users] Patch for bytecode tagging

Hi Eric, thanks for accepting the patch.

There are two new instruction kind tags: CONTEXT_EXPOSURE and PARAMETER_BACKUP.
CONTEXT_EXPOSURE is applied to bytecodes that place the value of join
point parameters into local variables for consumption by the advice.
PARAMETER_BACKUP is not used yet, but should be applied to bytecodes
that place the value of join point parameters into local variables not
for the advice but just for some bookkeeping.

Regarding the inlining thing, it seems the issue was that the
CombinedInlineOptions class groups several options together. So it was
not correct to check for inlining options just by doing an instanceof
on the InlineOptions object. Instead I added a method hasOption that
takes an option class and indicates if the option is set. For most
cases it is basically an instanceof (actually Class.isAssignableFrom),
but for CombinedInlineOptions it recursively checks sub-options.

Regards,
g

On Tue, Aug 19, 2008 at 12:17 PM, Eric Bodden
<eric.bodden_at_mail.mcgill.ca> wrote:
> Committed as revision 6175.
>
> Eric
>
> 2008/8/19 Eric Bodden <eric.bodden_at_mail.mcgill.ca>:
>> Thanks, Guillaume.
>>
>> I think the patch looks ok. I would just like to to ask you whether
>> you could send us a small paragraph that we could put into our
>> changelog, explaining the two new tags, why they were introduced and
>> maybe even explaining the fix to the around inliner if you can at all
>> remember.
>>
>> I am currently test-running the patch and I will commit it if it
>> doesn't break anything.
>>
>> Thanks again,
>> Eric
>>
>> 2008/8/18 Guillaume Pothier <gpothier_at_gmail.com>:
>>> Hi,
>>> Some time ago I started to modify a bit the tagging scheme of abc in
>>> order to suit the needs of TOD (http://pleiad.dcc.uchile.cl/tod), an
>>> omniscient debugger for Java and AspectJ. More precisely, I added two
>>> new instruction kind tags and fixed the tagging in some places, as it
>>> produced erroneous tags sometimes.
>>> I also fixed an issue with inlining, but it has been some time since I
>>> did it so I don't exactly remember what was the problem...
>>>
>>> Anyway, here comes a first version of the patch. Please tell me if it
>>> is acceptable, or if it needs more work. It was generated against
>>> today's svn.
>>>
>>> Regards,
>>> g
>>>
>>
>>
>>
>> --
>> Eric Bodden
>> Sable Research Group
>> McGill University, Montréal, Canada
>>
>
>
>
> --
> Eric Bodden
> Sable Research Group
> McGill University, Montréal, Canada
>
>
Received on Wed Aug 20 2008 - 18:11:13 BST